OpenBC FFT Solver: Fix 2d mode bug#4703
Merged
ax3l merged 1 commit intoAMReX-Codes:developmentfrom Oct 8, 2025
Merged
Conversation
PR AMReX-Codes#4671 did not fix all the issues with the 2d mode OpenBC FFT solver in 3D WarpX/ImpactX runs. The scaling was still wrong.
13 tasks
ax3l
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4671 did not fix all the issues with the 2d mode OpenBC FFT solver in 3D WarpX/ImpactX runs. The scaling was still wrong.