Fix Windows/MSVC members of template class and include <limits> for C++20#4688
Merged
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom Sep 30, 2025
Merged
Fix Windows/MSVC members of template class and include <limits> for C++20#4688WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
Conversation
- in AMReX_MLCellLinOp.H: Added 'this->' to access dependent members of template classes to resolve MSVC C2065 errors. - in AMReX_Math.H: Added #include <limits> to enable C++20 compilation on Windows (MSVC and Intel OneAPI).
WeiqunZhang
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix MSVC members of template class and
#include <limits>(also for Intel OneAPI) forC++20this->to access dependentmembers of template classes to resolve MSVC C2065 errors.
#include <limits>compilation on Windows (MSVC and Intel OneAPI).