OpenBC FFT Solver: Fix a 2d mode bug.#4671
Merged
ax3l merged 1 commit intoAMReX-Codes:developmentfrom Sep 23, 2025
Merged
Conversation
This bug only affected 3D WarpX/ImpactX when there was only one cell in the z-direction for the solver. The fix is that we have simplified the logic for handling domain decomposition. If it's in the 2D mode in 3D, we simply do slab decomposition.
WeiqunZhang
force-pushed
the
fix_openbc_2d_mode
branch
from
cf5c532 to
e4f2800
Compare
13 tasks
EZoni
pushed a commit
to BLAST-WarpX/warpx
that referenced
this pull request
Sep 23, 2025
Mainly to pull in AMReX-Codes/amrex#4671 Also updates pybind11 to [v3.0.1](https://github.com/pybind/pybind11/releases/tag/v3.0.1), to stay in sync with [pyAMReX](AMReX-Codes/pyamrex#481). <hr> Weekly update to latest AMReX. Weekly update to latest pyAMReX. Weekly update to latest PICSAR (no changes). ```console ./Tools/Release/update_dependencies.py --amrex ./Tools/Release/update_dependencies.py --pyamrex ./Tools/Release/update_dependencies.py --picsar ``` This pull request was created with the script `./Tools/Release/weeklyUpdate.py`, following the instructions described in https://warpx.readthedocs.io/en/latest/maintenance/release.html#update-warpx-core-dependencies. --------- Signed-off-by: Axel Huebl <[email protected]>
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Oct 7, 2025
PR AMReX-Codes#4671 did not fix all the issues with the 2d mode OpenBC FFT solver in 3D WarpX/ImpactX runs. The scaling was still wrong.
ax3l
pushed a commit
that referenced
this pull request
Oct 8, 2025
PR #4671 did not fix all the issues with the 2d mode OpenBC FFT solver in 3D WarpX/ImpactX runs. The scaling was still wrong.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Dec 3, 2025
They used to work, but were broken in AMReX-Codes#4671.
WeiqunZhang
added a commit
that referenced
this pull request
Dec 3, 2025
They used to work, but were broken in #4671.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug only affected 3D WarpX/ImpactX when there was only one cell in the z-direction for the solver.
The fix is that we have simplified the logic for handling domain decomposition. If it's in the 2D mode in 3D, we simply do slab decomposition.