Remove no-op Fortran *_destroy blocks (#4666)#4667
Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom Sep 23, 2025
Merged
Remove no-op Fortran *_destroy blocks (#4666)#4667WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
Conversation
Member
Member
|
Either only nvfotran sees it or only ifx does not is fine with me. |
Member
|
Let's also add a line to compile the fortran code with ifx in CI. |
Member
Ignore this. That seems to cause some other compiler issues at link time. |
zjibben
force-pushed
the
development
branch
from
72d45f0 to
c58f15c
Compare
Contributor
Author
|
@WeiqunZhang Thanks for the feedback! I just pushed some changes so that the interfaces are only seen by nvfortran. We'll see if tests pass. |
WeiqunZhang
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #4666.
I was able to build my code on ifx without triggering ICE by removing these blocks. Turns out the ICE is triggered not just by finalizers, but any type-bound procedure which is also in an interface block and made independently public from the module, but fortunately I didn't find any such procedures in AMReX.
These blocks are no-ops and completely harmless to remove since they only contain single procedures each and don't rename anything. However if you prefer, since they are valid Fortran, we could wrap them in ifdefs so Intel compilers don't see them.
Additional background
These interface blocks trigger an ifx ICE on user codes which invoke
use ..., only:on AMReX modules.Checklist
The proposed changes: