Curl Curl Solver: Support for 1D spherical and 1D cylindrical#4611
Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom Sep 8, 2025
Merged
Curl Curl Solver: Support for 1D spherical and 1D cylindrical#4611WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WeiqunZhang
force-pushed
the
curlculr_sph
branch
from
9cda463 to
8925123
Compare
WeiqunZhang
changed the title
WeiqunZhang
force-pushed
the
curlculr_sph
branch
2 times, most recently
from
47c1d3b to
9bc1ef0
Compare
This PR adds support for 1D spherical and 1D cylindrical. Note that the curl of curl of E is zero in the radial direction. For 1D spherical coordinates, E_theta and E_phi have reflect-odd symmetry, and are thus zero at R = 0. For 1D cylindrical coordinates, E_theta has reflect-odd symmetry, and is thus zero at r = 0. E_z has reflect-even symmetry at r = 0, where the curl-curl is -4(Ez(1)-Ez(0))/dr^2 in the z-direction.
WeiqunZhang
force-pushed
the
curlculr_sph
branch
from
9bc1ef0 to
c95dc2d
Compare
Member
Author
|
Could we get this approved? It's a new feature that is used by WarpX in 1D. It will not break any other codes. |
asalmgren
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for 1D spherical and 1D cylindrical. Note that the curl of curl of E is zero in the radial direction. For 1D spherical coordinates, E_theta and E_phi have reflect-odd symmetry, and are thus zero at R = 0. For 1D cylindrical coordinates, E_theta has reflect-odd symmetry, and is thus zero at r = 0. E_z has reflect-even symmetry at r = 0, where the curl-curl is -4(Ez(1)-Ez(0))/dr^2 in the z-direction.