SIMD: Remove Unnecessary Namespaces#4600
Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom Aug 7, 2025
Merged
Conversation
With `vir-simd`, we do not need these namespaces anymore. They are in fact not available on macOS/Windows by default.
ax3l
force-pushed
the
fix-simd-namespaces
branch
from
f8a306f to
27d65e9
Compare
WeiqunZhang
approved these changes
Aug 7, 2025
ax3l
added a commit
that referenced
this pull request
Feb 7, 2026
## Summary Needed to cover SIMD features and generic SIMD/non-SIMD patterns. Bravely vibe coded, but now reviewed and improved for sensibility. ## Additional background #4924 #4607 #4600 #4520 ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate --------- Co-authored-by: Weiqun Zhang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
vir-simd, we do not need these namespaces anymore. They are in fact not available on macOS/Windows by default.Additional background
conda-forge/amrex-feedstock#60
Checklist
The proposed changes: