Modify how we interpolate velocity from faces to particle position; f…#4598
Merged
asalmgren merged 2 commits intoAMReX-Codes:developmentfrom Aug 5, 2025
Merged
Conversation
…or vertical velocities we always want to use the cell of the particle location
atmyers
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or vertical velocities we always want to use the cell of the particle location
Summary
The previous interpolation scheme tested on where the particle location was relative to the plane between the face velocities; for the vertical velocities we don't want to do this because we always want to use the velocities at the k location of the particle position (otherwise there is a discrepancy between the particle being identified as in cell k but being below the threshhold for using the vertical velocities associated with cell k)
Additional background
Note this only affects cases where the velocity components are on faces and where the mesh is "distorted", i.e. with terrain-following coordinates
Checklist
The proposed changes: