Skip to content

Modify how we interpolate velocity from faces to particle position; f…#4598

Merged
asalmgren merged 2 commits intoAMReX-Codes:developmentfrom
asalmgren:fix_interpolation_with_terrain
Aug 5, 2025
Merged

Modify how we interpolate velocity from faces to particle position; f…#4598
asalmgren merged 2 commits intoAMReX-Codes:developmentfrom
asalmgren:fix_interpolation_with_terrain

Conversation

@asalmgren
Copy link
Copy Markdown
Member

…or vertical velocities we always want to use the cell of the particle location

Summary

The previous interpolation scheme tested on where the particle location was relative to the plane between the face velocities; for the vertical velocities we don't want to do this because we always want to use the velocities at the k location of the particle position (otherwise there is a discrepancy between the particle being identified as in cell k but being below the threshhold for using the vertical velocities associated with cell k)

Additional background

Note this only affects cases where the velocity components are on faces and where the mesh is "distorted", i.e. with terrain-following coordinates

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

…or vertical velocities we always want to use the cell of the particle location
@asalmgren asalmgren requested a review from atmyers August 5, 2025 00:00
@asalmgren asalmgren enabled auto-merge (squash) August 5, 2025 14:28
@asalmgren asalmgren merged commit 4bc33c7 into AMReX-Codes:development Aug 5, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants