Add ParallelForOMP#4595
Merged
WeiqunZhang merged 3 commits intoAMReX-Codes:developmentfrom Aug 8, 2025
Merged
Conversation
WeiqunZhang
force-pushed
the
parallelfor_omp
branch
from
20b6c61 to
8ccfcb5
Compare
Member
Author
|
If needed, we can extend this to support BoxND. |
ParallelFor does not do any OMP threading, because we do coarse-grained OMP threading at the MFIter level with tiling. But there are cases we use ParallelFor outside MFIter and they could benefit from OMP threading. Thus, we add new ParallelForOMP functions in this PR. Note that OMP threading is used only for CPU builds with OMP, otherwise the new ParallelForOMP functions are equivalent to ParallelFor functions.
WeiqunZhang
force-pushed
the
parallelfor_omp
branch
from
8ccfcb5 to
e522e7e
Compare
atmyers
reviewed
Aug 8, 2025
Co-authored-by: Andrew Myers <[email protected]>
atmyers
approved these changes
Aug 8, 2025
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Aug 11, 2025
GCC does have allow omp collapse on loops marked with ivdep.
WeiqunZhang
added a commit
that referenced
this pull request
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParallelFor does not do any OMP threading, because we do coarse-grained OMP threading at the MFIter level with tiling. But there are cases we use ParallelFor outside MFIter and they could benefit from OMP threading. Thus, we add new ParallelForOMP functions in this PR. Note that OMP threading is used only for CPU builds with OMP, otherwise the new ParallelForOMP functions are equivalent to ParallelFor functions.