Fix GPU communication for non-arithmetic types#4515
Merged
WeiqunZhang merged 15 commits intoAMReX-Codes:developmentfrom Jun 21, 2025
Merged
Fix GPU communication for non-arithmetic types#4515WeiqunZhang merged 15 commits intoAMReX-Codes:developmentfrom
WeiqunZhang merged 15 commits intoAMReX-Codes:developmentfrom
Conversation
WeiqunZhang
force-pushed
the
fab_to_fab_t
branch
from
9bf811e to
2e1102a
Compare
bsrunnels
approved these changes
Jun 19, 2025
WeiqunZhang
force-pushed
the
fab_to_fab_t
branch
from
02b5729 to
d49e211
Compare
atmyers
approved these changes
Jun 21, 2025
5 tasks
WeiqunZhang
pushed a commit
that referenced
this pull request
Sep 8, 2025
This PR removes the `sycl::nd_item<1>` that `detail::ParallelFor_doit` passes into the function it was called with. As far as I can tell #4515 removed the last usage of the nd item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on Nvidia GTX 1060, GV100, V100, A100 and H100, AMD MI250X and MI300A, and Intel PVC.