Replaced depreciated cub::Max, cub::Min cub::Sum with cuda::maximum<>…#4500
Merged
WeiqunZhang merged 5 commits intoAMReX-Codes:developmentfrom Jun 11, 2025
Merged
Conversation
… cuda::minimum<>, cuda::std::plus<>
Member
|
I think we need to use |
ankithadas
force-pushed
the
CudaReplaceDepreciated
branch
from
c2e1b31 to
58b47a8
Compare
WeiqunZhang
approved these changes
Jun 11, 2025
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 8, 2025
There was an issue in AMReX-Codes#4500. It used CCCL_MAJOR_VERSION before it was defined in a header included by cub.cuh. Use CUDA 13 in one of the CI test.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 8, 2025
There was an issue in AMReX-Codes#4500. It used CCCL_MAJOR_VERSION before it was defined in a header included by cub.cuh. Use CUDA 13 in one of the CI tests.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 8, 2025
There was an issue in AMReX-Codes#4500. It used CCCL_MAJOR_VERSION before it was defined in a header included by cub.cuh. Use CUDA 13 in one of the CI tests. Note that we need to install a newer version of cmake that supports CUDA 13.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 8, 2025
There was an issue in AMReX-Codes#4500. It used CCCL_MAJOR_VERSION before it was defined in a header included by cub.cuh. Use CUDA 13 in one of the CI tests. Note that we need to install a newer version of cmake that supports CUDA 13.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 8, 2025
There was an issue in AMReX-Codes#4500. It used CCCL_MAJOR_VERSION before it was defined in a header included by cub.cuh. Use CUDA 13 in one of the CI tests. Note that we need to install a newer version of cmake that supports CUDA 13.
Merged
WeiqunZhang
added a commit
that referenced
this pull request
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… cuda::minimum<>, cuda::std::plus<>
X-Ref: https://nvidia.github.io/cccl/cccl/3.0_migration_guide.html