ParmParse:addFile: User-Friendly Error#4156
ParmParse:addFile: User-Friendly Error#4156WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
ParmParse:addFile: User-Friendly Error#4156Conversation
If a file added via `ParmParse:addFile` does not exist, we did not yet receive a user-friendly error message. This fixes this in a way that does not hammer the file system from all MPI ranks.
8f76989 to
41d0284
Compare
|
I thought it's going to say something like Anyway there is a function called |
|
So it could just |
|
Thanks! Yes the error message I got so far looks not as clean as it could be. If we do the check & abort inside an |
|
To prevent other errors later, a barrier should be enough. |
|
There is already a barrier after this in reading and bcast the file, which also produce |
|
My point is the fewer lines of code, the better, unless the code is hard to read. |
0e2b8cb to
058838a
Compare
Summary
If a file added via
ParmParse:addFiledoes not exist, we did not yet receive a user-friendly error message. This fixes this in a way that does not hammer the file system from all MPI ranks.Additional background
Follow-up to #2842 #2936 #3440
X-ref: BLAST-WarpX/warpx#5283 BLAST-ImpactX/impactx#704
Checklist
The proposed changes: