Fix Fortran interface compilation issue using nvfortran#4115
Merged
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom Sep 2, 2024
Merged
Fix Fortran interface compilation issue using nvfortran#4115WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
nvfortran#4115WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
Conversation
this bypasses compilation issue using `nvfortran`
WeiqunZhang
approved these changes
Sep 2, 2024
5 tasks
WeiqunZhang
pushed a commit
that referenced
this pull request
Sep 23, 2025
## Summary Resolves #4666. I was able to build my code on ifx without triggering ICE by removing these blocks. Turns out the ICE is triggered not just by finalizers, but any type-bound procedure which is also in an interface block and made independently public from the module, but fortunately I didn't find any such procedures in AMReX. These blocks are no-ops and completely harmless to remove since they only contain single procedures each and don't rename anything. However if you prefer, since they are valid Fortran, we could wrap them in ifdefs so Intel compilers don't see them. ## Additional background These interface blocks trigger an ifx ICE on user codes which invoke `use ..., only:` on AMReX modules. The interfaces were added in #4115 to address an nvfortran issue. -- Weiqun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will fix the compilation issue for Fortran interfaces when using
nvfortran, reported in #4111.Additional background
The new
module procedureinterfaces forfinalsubroutines are introduced to bypass thenvfortrancompilation error. This change may not be needed according to the Fortran standard, but it effectively resolves compilation errors usingnvfortranwith-DAMReX_FORTRAN_INTERFACES=ON.Checklist
The proposed changes: