ParmParse: Refactoring#4031
Merged
asalmgren merged 1 commit intoAMReX-Codes:developmentfrom Jul 22, 2024
Merged
Conversation
WeiqunZhang
force-pushed
the
refactor_parmparse
branch
5 times, most recently
from
eebe30c to
9876da3
Compare
ParmParse has been refactored for much better performance when there are a large number of entries. The implementation now uses std::vector instead of std::list. This commit also removes two unused features, ParmParse::Record and ParmParse::Frame.
WeiqunZhang
force-pushed
the
refactor_parmparse
branch
from
9876da3 to
4bb4970
Compare
This was referenced Jul 16, 2024
asalmgren
approved these changes
Jul 22, 2024
14 tasks
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Aug 15, 2025
It was removed in AMReX-Codes#4031. But it is still used by ImpactX in an assert, and it is still useful.
ax3l
pushed a commit
that referenced
this pull request
Aug 18, 2025
It was removed in #4031. But it is still used by ImpactX in an assert, and it is still useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParmParse has been refactored for much better performance when there are a large number of entries. The implementation now uses std::vector instead of std::list. This commit also removes two unused features, ParmParse::Record and ParmParse::Frame.