Merged
Conversation
- Fixed Make.catalyst include directories - Added SoA particle support to Conduit blueprints - Added AMReX_Conduit_Blueprint_ParticlesI.H to Conduit Make.package - Fixed whitespaces
Co-authored-by: Corey Wetterer-Nelson <[email protected]>
6 tasks
ax3l
approved these changes
Jul 30, 2024
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
That looks great, thank you!
Sorry for the slow reply due to vacation and work travel in the last month.
Member
|
Hi @ChristosT, do you plan to also replace BLAST-WarpX/warpx#4121 with a new PR? 🤩 |
3 tasks
ax3l
reviewed
Jul 30, 2024
| env: | ||
| CXX: g++ | ||
| CC: gcc | ||
| CMAKE_PREFIX: "/opt/conduit;/opt/catalyst" |
Member
There was a problem hiding this comment.
@ChristosT did you mean to write here
Suggested change
| CMAKE_PREFIX: "/opt/conduit;/opt/catalyst" | |
| CMAKE_PREFIX_PATH: "/opt/conduit:/opt/catalyst" |
?
5 tasks
ax3l
added a commit
that referenced
this pull request
Aug 6, 2024
## Summary This appears to be a typo: - env variable is `CMAKE_PREFIX_PATH` - on Unix, paths are separated by `:` (Windows is `;`) ## Additional background Follow-up to #4011 cc @ChristosT @c-wetterer-nelson ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
Contributor
Author
Yes ! I have it running . But I am on vacation right now. I will come back to it before the end of the month :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the work of @andrewcombs and @c-wetterer-nelson from #3444 by adding a docker image that includes ParaView and can be used for testing.
It also adds a minor fix a02c1a5 discovered when testing these changes with the current master of WarpX.
Additional background
Supersedes and closes #3444
Checklist
The proposed changes: