Update SUNDIALS support to SUNDIALS v7.0.0#3756
Closed
balos1 wants to merge 2 commits intoAMReX-Codes:developmentfrom
Closed
Update SUNDIALS support to SUNDIALS v7.0.0#3756balos1 wants to merge 2 commits intoAMReX-Codes:developmentfrom
balos1 wants to merge 2 commits intoAMReX-Codes:developmentfrom
Conversation
Member
|
We do want to make sure the old versions work too. It should not be hard by using the |
Contributor
Author
|
Sounds good. If you can finish it up that would be great. If you have any issues just let me know. |
Member
|
Great. Since I cannot push to your branch, I will close this PR. Then I will cherry pick your commits and start from there. Thanks! |
Merged
ax3l
added a commit
that referenced
this pull request
Mar 27, 2024
This is the rebirth of #3756. But it's compatible with SUNDIALS 6. --------- Co-authored-by: Balos, Cody, J <[email protected]> Co-authored-by: Cody Balos <[email protected]> Co-authored-by: Axel Huebl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the SUNDIALS interface to SUNDIALS v7.0.0, which will be released at the end of the month.
Additional background
This PR breaks support for SUNDIALS < v7. I don't think it would difficult to support both versions if that is desired. A release candidate for SUNDIALS v7 is 'released' and tagged, but there will be a few more updates in the final v7 that currently sit in sundials@develop.
Checklist
The proposed changes: