move redist into amrex#3378
Merged
WeiqunZhang merged 32 commits intoAMReX-Codes:developmentfrom Jul 3, 2023
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…nto move_redist_into_amrex
| int domhi_x, int domhi_y, int domhi_z, | ||
| int max_order) noexcept | ||
| { | ||
| constexpr int dim_a = 125; |
Check notice
Code scanning / CodeQL
Unused local variable
| int domhi_x, int domhi_y, int domhi_z, | ||
| int max_order) noexcept | ||
| { | ||
| constexpr int dim_a = 27; |
Check notice
Code scanning / CodeQL
Unused local variable
…nto move_redist_into_amrex
WeiqunZhang
force-pushed
the
move_redist_into_amrex
branch
from
48d94cb to
19b62d1
Compare
This was referenced Jun 28, 2023
Merged
WeiqunZhang
approved these changes
Jul 3, 2023
This was referenced Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves all redistribution functionality from AMReX-Hydro to amrex/Src/EB. It also adds re-redistribution to the routines in EB (copied from Tests/EB_CNS). (It also moves the slope routines since those are needed by state redistribution.) This change will require changes in any code that currently uses AMReX-Hydro for redistribution. Additional changes will be required in application codes that want to enable re-redistribution. Once this PR is merged in amrex, all routines in AMReX-Hydro/Slopes and AMReX-Hydro/Redistribution will be deleted.
Additional background
Checklist
The proposed changes: