cleaning and fixes for PureSoA ParticleTile#3327
Merged
atmyers merged 4 commits intoAMReX-Codes:developmentfrom May 24, 2023
Merged
Conversation
Member
|
Epic changes all along. Thanks a lot! 🚀 ✨ |
ax3l
approved these changes
May 24, 2023
atmyers
reviewed
May 24, 2023
|
|
||
| [[nodiscard]] bool empty () const { return m_data.empty(); } | ||
|
|
||
| [[nodiscard]] const RealType* data () const { return &(m_data[0].m_pos[0]); } |
Member
There was a problem hiding this comment.
I agree that these are weird, but unfortunately they are needed for backwards compatibility with codes that still pass particle structs into Fortran subroutines.
Member
There was a problem hiding this comment.
Should we potentially make the void* pointers to reflect what they do?
(Can be a separate PR.)
Member
There was a problem hiding this comment.
Ah I see, changed to ParticleType* is also good.
atmyers
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id()andcpu()withdecltype(auto)dataanddataPtrformArrayOfStructs(they should have returned ParticleType* but returned the position array of the first particle)packParticleDataandunpackParticleDatafor PureSoAgetSuperParticleand addsetSuperParticlefor PureSoA. Remaining issue: super particle has redundant/unused fields for positions, id and cpuConstParticleTileDatafor PureSoAgetParticleTileDatainParticleTile::id()etc. as this could be very slow if used in a for loopgetParticleTileData()won't allocate memory if no runtime components are usedAdditional background
Follow-up to #2878.
Checklist
The proposed changes: