Skip to content

Fix: AMReXConfig.cmake Multi-Dim#3324

Merged
ajnonaka merged 2 commits intoAMReX-Codes:developmentfrom
ax3l:fix-cmake-config
May 22, 2023
Merged

Fix: AMReXConfig.cmake Multi-Dim#3324
ajnonaka merged 2 commits intoAMReX-Codes:developmentfrom
ax3l:fix-cmake-config

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented May 22, 2023

Summary

Fix two regressions from #3309 in the installed AMReXConfig.cmake:

CMake Error at lib/cmake/AMReX/AMReXConfig.cmake:257 (add_library):
  add_library cannot create ALIAS target "AMReX::amrex" because another
  target with the same name already exists.

and setting properties for newer CUDA.

Additional background

Regression to #3309, spotted by @drangara, @ajnonaka, wdf et al.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l
Fix: AMReXConfig.cmake Multi-Dim
a8250a3 
Fix two regressions from AMReX-Codes#3309 in the installed `AMReXConfig.cmake`:
```
CMake Error at /scratch/AMReX_RegTesting/amrex/builddir/lib/cmake/AMReX/AMReXConfig.cmake:257 (add_library):
  add_library cannot create ALIAS target "AMReX::amrex" because another
  target with the same name already exists.
```

and setting properties for newer CUDA.
@ax3l ax3l requested review from WeiqunZhang and ajnonaka May 22, 2023 22:13
@ax3l ax3l changed the title [WIP] Fix: AMReXConfig.cmake Multi-Dim Fix: AMReXConfig.cmake Multi-Dim May 22, 2023
@ax3l ax3l force-pushed the fix-cmake-config branch from 397329c to bbc6665 Compare May 22, 2023 22:22
@ax3l ax3l mentioned this pull request May 22, 2023
Merged
8 tasks
@ax3l ax3l force-pushed the fix-cmake-config branch from bbc6665 to 27683d5 Compare May 22, 2023 22:25
@ajnonaka
Copy link
Copy Markdown
Contributor

ajnonaka commented May 22, 2023

This fixes the regression tests on biollante. Thanks @ax3l !!!

@ajnonaka ajnonaka enabled auto-merge (squash) May 22, 2023 22:30
@ax3l
Copy link
Copy Markdown
Member Author

ax3l commented May 22, 2023

Thank you for the quick & detailed report 🙏 🎉

@ajnonaka ajnonaka merged commit 1881aca into AMReX-Codes:development May 22, 2023
@ax3l ax3l deleted the fix-cmake-config branch May 22, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajnonaka ajnonaka ajnonaka approved these changes

@WeiqunZhang WeiqunZhang Awaiting requested review from WeiqunZhang

Assignees

No one assigned

Labels

bug install

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ax3l @ajnonaka