Skip to content

Fixing the ParIter numParticles functions for pure SOA#3303

Merged
ax3l merged 1 commit intoAMReX-Codes:developmentfrom
atmyers:par_iter_soa_fix
May 9, 2023
Merged

Fixing the ParIter numParticles functions for pure SOA#3303
ax3l merged 1 commit intoAMReX-Codes:developmentfrom
atmyers:par_iter_soa_fix

Conversation

@atmyers
Copy link
Copy Markdown
Member

@atmyers atmyers commented May 8, 2023

Follow-up to #2878.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from ax3l May 8, 2023 22:39
@ax3l ax3l self-assigned this May 9, 2023
@ax3l ax3l added the bug label May 9, 2023
Copy link
Copy Markdown
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ✨

@ax3l ax3l merged commit d01b15c into AMReX-Codes:development May 9, 2023
guj pushed a commit to guj/amrex that referenced this pull request Jul 13, 2023
)

The proposed changes:
- [x] fix a bug or incorrect behavior in AMReX
- [ ] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX
users
- [ ] include documentation in the code and/or rst files, if appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants