ParticleTileData: No Restrict in Storage#3245
Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom Apr 7, 2023
Merged
ParticleTileData: No Restrict in Storage#3245WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
Conversation
Remove the `restrict` qualifier from `GpuArray` members in `ParticleTileData`. We see compilation problems with, among others Clang 14.0.6 and AppleClang, for this construct. We expect that using `restrict` (`AMREX_RESTRICT`) on APIs as well as aliased pointers in these arrays before access should be sufficient to prevent that the compiler thinks that individual arrays alias each other in hot loops.
ax3l
force-pushed
the
topic-ptd-member-norestrict
branch
from
cdd6877 to
c49f78f
Compare
WeiqunZhang
approved these changes
Apr 7, 2023
1 task
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Jul 13, 2023
## Summary Remove the `restrict` qualifier from `GpuArray` members in `ParticleTileData`. We see compilation problems with, among others Clang 14.0.6 and AppleClang, for this construct. We expect that using `restrict` (`AMREX_RESTRICT`) on APIs as well as aliased pointers in these arrays before access should be sufficient to prevent that the compiler thinks that individual arrays alias each other in hot loops. ## Additional background - WarpX build regressions since 23.03, e.g., - conda-forge/warpx-feedstock#63 - conda-forge/warpx-feedstock#64 - BLAST-WarpX/warpx#3817 - independently, about to be remove in AMReX-Codes#2878
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
restrictqualifier fromGpuArraymembers inParticleTileData. We see compilation problems with, among others Clang 14.0.6 and AppleClang, for this construct.We expect that using
restrict(AMREX_RESTRICT) on APIs as well as aliased pointers in these arrays before access should be sufficient to prevent that the compiler thinks that individual arrays alias each other in hot loops.Additional background
Checklist
The proposed changes: