Skip to content

Update for oneAPI 2023#3024

Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
WeiqunZhang:oneapi_2023
Nov 16, 2022
Merged

Update for oneAPI 2023#3024
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
WeiqunZhang:oneapi_2023

Conversation

@WeiqunZhang
Copy link
Copy Markdown
Member

@WeiqunZhang WeiqunZhang commented Nov 6, 2022

A number of things have been deprecated and need to be updated.

  • dpcpp -> icpx

  • sycl::gpu_selector -> sycl::gpu_selector_v

  • sycl::info::device::max_work_item_sizes -> sycl::info::device::max_work_item_sizes<3>

  • sycl::accessor<...,sycl::access::target::local> -> sycl_local_accessor

  • CL/sycl.hpp -> sycl/sycl.hpp

Also remove AMREX_GPU_EXTERNAL because SYCL_EXTERNAL never worked for us.

@WeiqunZhang WeiqunZhang force-pushed the oneapi_2023 branch 7 times, most recently from a7e621e to f535dbe Compare November 6, 2022 22:32
A number of things have been deprecated and need to be updated.

  - dpcpp -> icpx

  - sycl::gpu_selector -> sycl::gpu_selector_v

  - sycl::info::device::max_work_item_sizes ->
    sycl::info::device::max_work_item_sizes<3>

  - sycl::accessor<...,sycl::access::target::local> -> sycl_local_accessor

  - CL/sycl.hpp -> sycl/sycl.hpp

Also remove AMREX_GPU_EXTRENAL because SYCL_EXTERNAL never worked for us.
@WeiqunZhang
Copy link
Copy Markdown
Member Author

@nmnobre I think this should work for you.

@WeiqunZhang
Copy link
Copy Markdown
Member Author

If there are any other issues, let me know.

@nmnobre
Copy link
Copy Markdown
Contributor

nmnobre commented Nov 11, 2022

Thanks a lot.
Just to be clear, I'm happy with waiting until they officially release 2023.x so we can avoid the preprocessor conditional, but I'm also happy with this temporary workaround if you are.

@WeiqunZhang WeiqunZhang merged commit 6d9dcd9 into AMReX-Codes:development Nov 16, 2022
@WeiqunZhang WeiqunZhang deleted the oneapi_2023 branch November 16, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants