Skip to content

add Ok to coordsys#2844

Merged
atmyers merged 1 commit intoAMReX-Codes:developmentfrom
RTSandberg:topic-coordsysOk
Jun 21, 2022
Merged

add Ok to coordsys#2844
atmyers merged 1 commit intoAMReX-Codes:developmentfrom
RTSandberg:topic-coordsysOk

Conversation

@RTSandberg
Copy link
Copy Markdown
Member

@RTSandberg RTSandberg commented Jun 17, 2022

Summary

Add convenience function letting something check if a coordsys object is is ok, meaning it has been properly defined

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l requested a review from WeiqunZhang June 20, 2022 07:32
Copy link
Copy Markdown
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@atmyers atmyers merged commit 104466d into AMReX-Codes:development Jun 21, 2022
ax3l added a commit to ax3l/impactx that referenced this pull request Jun 22, 2022
ax3l added a commit to BLAST-ImpactX/impactx that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants