Merged
Conversation
We are using `find_package(CUDAToolkit ...)` now, which is only supported in CMake 3.17+. Technically, we want to go to 3.20+ soon as well, so that we can drop the old CUDA code paths that we used to forward device flags and CUDA architectures.
atmyers
approved these changes
Jun 7, 2022
ax3l
added a commit
to ax3l/amrex
that referenced
this pull request
Jun 8, 2022
Already searched for since AMReX-Codes#2813
ax3l
commented
Jun 8, 2022
| # Add manually nvToolsExt if tiny profiler or base profiler are on.n | ||
| # Add manually nvToolsExt if tiny profiler or base profiler are on. | ||
| # CMake >= 3.17 provides the module FindCUDAToolkit to do this natively. | ||
| # TODO: Modernize me, now that we require CMake 3.17+. |
Member
Author
There was a problem hiding this comment.
Upsi, forgot to add this patch in the last commit.
Follow-up in #2817
atmyers
pushed a commit
that referenced
this pull request
Jun 8, 2022
Already searched for since #2813
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We are using
find_package(CUDAToolkit ...)now, which is only supported in CMake 3.17+.Follow-up to #2757
Additional background
Technically, we want to go to 3.20+ soon as well, so that we can drop the old CUDA code paths that we used to forward device flags and CUDA architectures.
Checklist
The proposed changes: