Skip to content

CUDA On Cray: More Robust w/o Wrapper#2757

Merged
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
ax3l:cuda-more-robust-cray
May 10, 2022
Merged

CUDA On Cray: More Robust w/o Wrapper#2757
WeiqunZhang merged 1 commit intoAMReX-Codes:developmentfrom
ax3l:cuda-more-robust-cray

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented May 9, 2022

Summary

Searching for curand explicitly (required by default by AMReX) makes HPE/Cray builds more robust when we build w/o compiler wrappers, e.g., if files are distributed in a non-standard layout.

Additional background

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7247

Compile error on Perlmutter with g++ and nvcc as compilers was:

                 from /global/homes/a/ahuebl/src/amrex/Src/Base/AMReX_Utility.cpp:4:
/global/homes/a/ahuebl/src/amrex/Src/Base/AMReX_RandomEngine.H:14:10: fatal error: curand.h: No such file or directory
   14 | #include <curand.h>
      |          ^~~~~~~~~~

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

Searching for `curand` explicitly (required by default by AMReX)
makes build more robust when we build w/o compiler wrappers.
@WeiqunZhang WeiqunZhang merged commit c4ad207 into AMReX-Codes:development May 10, 2022
@ax3l ax3l deleted the cuda-more-robust-cray branch June 6, 2022 20:11
This was referenced Jun 7, 2022
@ax3l ax3l mentioned this pull request Jun 14, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants