CI: macOS Shared Lib#1836
Merged
WeiqunZhang merged 9 commits intoAMReX-Codes:developmentfrom Mar 15, 2021
Merged
Conversation
Build a shared library. This is the default in Spack. I see issues with AppleClang 12.0 raising: ``` ld: can't use -undefined warning or suppress with -twolevel_namespace ```
2nd build should speed up with this.
ax3l
commented
Mar 4, 2021
ax3l
commented
Mar 4, 2021
ax3l
commented
Mar 4, 2021
ax3l
commented
Mar 4, 2021
maybe with a leading underscore?
ax3l
commented
Mar 4, 2021
ax3l
commented
Mar 4, 2021
ax3l
commented
Mar 4, 2021
Member
Author
|
Dang, what's the symbol name so I can put it on the command line to the linker Tried so many variants now, probably need to mangle it or so. |
ax3l
commented
Mar 4, 2021
ax3l
commented
Mar 4, 2021
ax3l
commented
Mar 4, 2021
Thanks wikipedia and godbolt!
ax3l
commented
Mar 4, 2021
ax3l
commented
Mar 4, 2021
9 tasks
WeiqunZhang
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI for macOS: Build a shared library. This is the default in Spack.
I see issues with AppleClang 12.0 raising:
@RemiLehe reported this again here: #425 (comment)
Additional background
Introduced in 1b6af3c to fix #425
Checklist
The proposed changes: