CMake: implement ability to export build tree#1149
Merged
ax3l merged 8 commits intoAMReX-Codes:developmentfrom Jul 22, 2020
Merged
CMake: implement ability to export build tree#1149ax3l merged 8 commits intoAMReX-Codes:developmentfrom
ax3l merged 8 commits intoAMReX-Codes:developmentfrom
Conversation
Just found out that: 1) We did not install typechecker 2) We do not need the typechecker path in the config file anymore
Contributor
Author
|
@sayerhs try this out and let me know if it works for you. |
sayerhs
approved these changes
Jul 19, 2020
mic84
changed the title
ax3l
reviewed
Jul 21, 2020
Co-authored-by: Axel Huebl <[email protected]>
ax3l
approved these changes
Jul 22, 2020
dwillcox
pushed a commit
to dwillcox/amrex
that referenced
this pull request
Oct 3, 2020
* CMake: define C++ required flags as a property of target amrex * CMake: fix handling of typechecker. Just found out that: 1) We did not install typechecker 2) We do not need the typechecker path in the config file anymore * CMake: enable exporting of build-tree * CMake: linking against Flags_CXX_REQUIRED not needed anymore * CMake: MSVC preprocessor flags must the public * CMake: one more instance of Flags_CXX_REQUIRED to get rid of * CMake: clean-up and add some comments * Update Tools/CMake/AMReXInstallHelpers.cmake Co-authored-by: Axel Huebl <[email protected]>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.