add configurable default_retry_after parameter#9
Merged
Conversation
Add default_retry_after parameter to BandcampAPIClient.init() to allow customization of the fallback value when the Retry-After header is missing from a 429 rate limit response. The default is changed from 30 to 10 seconds for improved responsiveness. Update tests/test_client.py assertions to expect the new 10 second default value in: test_rate_limit_error_default_retry_after test_rate_limit_error_invalid_retry_after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a configurable
default_retry_afterparameter toBandcampAPIClientfor customizing the fallback retry duration when rate limited (HTTP 429) without a Retry-After header. Changes the default from 30 to 10 seconds for faster recovery.Changes
default_retry_after: int = 10parameter toBandcampAPIClient.__init__()