Add BandcampRateLimitError exception for handling HTTP 429 (rate limit) responses from the Bandcamp API.#8
Merged
Conversation
- Add BandcampRateLimitError exception with retry_after attribute - Handle 429 status code in _request method before raise_for_status() - Parse Retry-After header with 30s default fallback for missing/invalid values - Export exception in __init__.py and add to __all__ - Add comprehensive tests for rate limit scenarios (GET and POST) - Document rate limiting with manual retry and tenacity examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Approach: The library raises an exception rather than handling retries internally, following modern patterns used by httpx, aiohttp, and requests. This gives callers full control over retry logic.