Fix collection/wishlist pagination returning no results#20
Merged
ALERTua merged 1 commit intoALERTua:mainfrom Mar 27, 2026
Merged
Fix collection/wishlist pagination returning no results#20ALERTua merged 1 commit intoALERTua:mainfrom
ALERTua merged 1 commit intoALERTua:mainfrom
Conversation
The collection and wishlist endpoints use "more_available" (not "has_more") to indicate additional pages. The library was reading a nonexistent key, always getting False, so only the first page was ever returned. Also use the last item's token as the pagination cursor instead of the response-level "last_token", which overshoots and causes duplicate items across pages. Added token field to CollectionItem model for consistency with FollowingItem and FanItem.
Closed
16 tasks
Owner
|
Thank you for your contribution and your findings. I will expand the tests and create a new release in the morning. The new release is expected to be created <12 hours from now. I will update this issue. |
Owner
|
https://github.com/ALERTua/bandcamp_async_api/releases/tag/0.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collection and wishlist endpoints use "more_available" (not "has_more") to indicate additional pages. The library was reading a nonexistent key, always getting False, so only the first page was ever returned.
Also use the last item's token as the pagination cursor instead of the response-level "last_token", which overshoots and causes duplicate items across pages.
Added token field to CollectionItem model for consistency with FollowingItem and FanItem.