Skip to content

Commit 5a3e368

Browse files
fix(server): detach errored provider sessions when deleting threads (pingdotgg#34199)
1 parent 3dfc1a0 commit 5a3e368

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

‎apps/server/src/orchestration-v2/ThreadDeletion.test.ts‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ it.effect("queues provider and resource cleanup and preserves an earlier deletio
279279
assert.deepEqual(deleted.thread.deletedAt, createdAt);
280280
assert.deepEqual(
281281
deleted.providerSessions.map((session) => session.status),
282-
["stopped", "error"],
282+
["stopped"],
283283
);
284284
assert.deepEqual(
285285
plan.effects.map((effect) => effect.request),
@@ -290,6 +290,12 @@ it.effect("queues provider and resource cleanup and preserves an earlier deletio
290290
detail: "Thread deleted.",
291291
revokeMcpCredential: true,
292292
},
293+
{
294+
type: "provider-session.detach",
295+
providerSessionId: ProviderSessionId.make("session:delete-plan:error"),
296+
detail: "Thread deleted.",
297+
revokeMcpCredential: true,
298+
},
293299
{ type: "scheduled-tasks.cleanup" },
294300
{ type: "terminal.cleanup" },
295301
{ type: "preview.cleanup" },

‎apps/server/src/orchestration-v2/ThreadDeletion.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,8 @@ export const planThreadDeletion = Effect.fn("ThreadDeletion.planThreadDeletion")
183183
}
184184

185185
for (const session of projection.providerSessions) {
186-
if (session.status === "stopped" || session.status === "error") continue;
186+
// An errored session can still own a reusable live runtime.
187+
if (session.status === "stopped") continue;
187188
yield* emitEvent({
188189
type: "provider-session.detached",
189190
threadId: command.threadId,

0 commit comments

Comments
 (0)