Skip to content

Commit 4f815d3

Browse files
AIdoesmyjobclaude
andcommitted
fix(skofo): drop our imageView branch now that upstream pingdotgg#30473 handles it; dedupe a test import
Upstream pingdotgg#30473 ("images the agent opens stay visible in the chat") handles Codex imageView items earlier in the same switch, via buildImageViewArtifacts with viewedImagePath. Our older branch became unreachable, and TypeScript narrowed it to never. The rest of our Codex image delta (generated-image handling) stays. The AgentSessionImporter test carried a duplicate TestClock import from the pingdotgg#22155 conflict resolution. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 68c308c commit 4f815d3

2 files changed

Lines changed: 0 additions & 22 deletions

File tree

‎apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -5525,27 +5525,6 @@ export const makeCodexAdapterV2 = Effect.fn("makeCodexAdapterV2")(function* (
55255525
return;
55265526
}
55275527

5528-
if (payload.item.type === "imageView") {
5529-
const artifacts = yield* buildDynamicToolArtifacts(context, {
5530-
type: "dynamicToolCall",
5531-
id: payload.item.id,
5532-
tool: "view_image",
5533-
arguments: { path: payload.item.path },
5534-
status: "completed",
5535-
});
5536-
yield* emitProviderEvent({
5537-
type: "node.updated",
5538-
driver: CODEX_PROVIDER,
5539-
node: artifacts.node,
5540-
});
5541-
yield* emitProviderEvent({
5542-
type: "turn_item.updated",
5543-
driver: CODEX_PROVIDER,
5544-
turnItem: { ...artifacts.turnItem, viewedImagePath: payload.item.path },
5545-
});
5546-
return;
5547-
}
5548-
55495528
if (payload.item.type !== "agentMessage") {
55505529
return;
55515530
}

‎apps/server/src/project/AgentSessionImporter.test.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import * as Layer from "effect/Layer";
2929
import * as Option from "effect/Option";
3030
import * as Stream from "effect/Stream";
3131
import * as SqlClient from "effect/sql/SqlClient";
32-
import * as TestClock from "effect/testing/TestClock";
3332

3433
import * as EventSink from "../orchestration-v2/EventSink.ts";
3534
import * as EventStore from "../orchestration-v2/EventStore.ts";

0 commit comments

Comments
 (0)