llvm 18 build fixes. #1940
Merged
llvm 18 build fixes. #1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@vanhauser-thc gonna love it :) I can kind of see why they removed the get*PtrTy shortcuts, but the starts_with/startswith situation is harder to comprehend .. we ll see. |
devnexen
force-pushed
the
llvm_18_build_fix
branch
from
99bbb2e to
2988573
Compare
Member
|
oh my what a shit show ... so many modules that need to be changed ... |
devnexen
force-pushed
the
llvm_18_build_fix
branch
from
16d6bf6 to
df0638a
Compare
Contributor
Author
|
I think I m done, with the last version from apt.llvm the build and tests pass locally. |
| FT->getNumParams() == 2 && FT->getReturnType()->isIntegerTy(32) && | ||
| FT->getParamType(0) == FT->getParamType(1) && | ||
| FT->getParamType(0) == IntegerType::getInt8PtrTy(M.getContext()); | ||
| FT->getParamType(0) == IntegerType::getInt8Ty(M.getContext())->getPointerTo(0); |
Member
There was a problem hiding this comment.
Does this not need an ifdef? Or does this work with llvm 11/13 too?
Contributor
Author
There was a problem hiding this comment.
Not at all, what the get*PtrTy did is precisely this, they were just shortcuts. llvm 18 feels like "api cleanup" (getFixedSize which calls geFixedValue is the same vein).
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.