Pass correct Nyx ID when creating a Nyx runner #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@schumilo fine with you? |
Contributor
|
Patch looks good and yes, this is indeed a silly bug we want to fix. We should probably also remove |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each Nyx instance requires a numeric id when being created. Nyx internally assumes that id 0 is the parent id and all non-zero ids are child instances that will run what the parent runs. For this purpose,
fsrv->nyx_idis actually populated with the id used with-M/-S. Mistakenly the code currently usesnyx_bind_cpu_idthough which works by coincidence if you only ever run a single AFL++ instance with-Mon a device and the CPU with id 0 is not busy already. Running two AFL++ instances with-Min parallel will cause a Nyx assertion to fail and reveals the failure.