Possible missing initialisation in custom mutator #1902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
you are correct, this was wrong. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Describe the bug
There could be a missing initialisation in the Custom Mutator stage. From what I understand, this check is meant to verify if the custom mutator's mutations have been added to the corpus. If so, the cycles for the custom mutator are increased. However, when the stage starts, or when each custom mutator is called, the
havoc_queuedvariable is not initialised withafl->queued_items.Expected behavior
If the initialisation is missing, the custom mutator's cycles could be wrongly extended.
Additional context
After reading the code, it seems like the Custom Mutator's code follows Havoc stage's code, which does initialise
havoc_queuedwithafl->queued_itemswhile initialising the stage for the current test case.I've noticed this while trying to understand better how the Custom Mutator API's is called. I'm sorry if this is not actually a bug!
Best,
Manuel.