Use proper AFL_NYX_AUX_SIZE for nyx_aux_string #1894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Cc @schumilo |
jschwartzentruber
added a commit
to MozillaSecurity/orion
that referenced
this pull request
Oct 20, 2023
Member
|
Lgtm |
jschwartzentruber
added a commit
to MozillaSecurity/orion
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, AFL_NYX_AUX_SIZE doesn't work because AFL++ uses the hardcoded 0x1000 size for
nyx_aux_stringrather than the actually set size. This causes ASan traces to still be truncated to 4K, no matter what AFL_NYX_AUX_SIZE is set to.The attached fix was validated to work in our setup and produces the proper traces now.