-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for UTF-8 line rendering #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Discussion point: do we want to go for UTF-8 by default? |
|
Hi! We only accept PRs to dev so I changed the destination for you. |
Ah, my bad. Thanks for changing the destination. |
|
sorry for the long wait, I have a lot on my plate ...
thank you! |
|
No worries, should be good to go. |
|
@andreafioraldi, I do not develop for Android, nor use adb. I see that you introduced the disabling of fancy_boxes for Android compilation. Does UTF-8 rendering work in adb as well? i.e. can we remove this compilation exception for Android? |
|
Andrea is on vacation currently. via adb the rendering is on the host so I do not see why this would break this. output on android itself (app, serial, ...) - but android's default is utf8 too. |
|
Sure, thing. Feel free to merge it in its current state. |
|
@vanhauser-thc, no clue why the test on Ubuntu-22.04 fails. Do you have any thoughts? |
|
The fail is a change in gcc, not important. |
Frustrated by the lack of support for the classic fancy boxes rendering in WSL terminals, I decided to add support for UTF-8 rendering.
default

makecompilation still yields:Optional

make UTF=1compilation now yields: