Skip to content

Conversation

@ThomasTNO
Copy link
Contributor

Frustrated by the lack of support for the classic fancy boxes rendering in WSL terminals, I decided to add support for UTF-8 rendering.

default make compilation still yields:
image

Optional make UTF=1 compilation now yields:
image

@ThomasTNO
Copy link
Contributor Author

Discussion point: do we want to go for UTF-8 by default?

@vanhauser-thc vanhauser-thc changed the base branch from stable to dev September 13, 2023 16:37
@vanhauser-thc
Copy link
Member

Hi! We only accept PRs to dev so I changed the destination for you.
Thanks for this, this looks valuable :)
Let me test on a few terminals tomorrow how it behaves if this can be the default

@ThomasTNO
Copy link
Contributor Author

Hi! We only accept PRs to dev so I changed the destination for you. Thanks for this, this looks valuable :) Let me test on a few terminals tomorrow how it behaves if this can be the default

Ah, my bad. Thanks for changing the destination.

@vanhauser-thc
Copy link
Member

sorry for the long wait, I have a lot on my plate ...
looks good to me and I am for having this the default, so could you please make the following changes

  • change UTF to NO_UTF in the GNUmakefile (and logic accordingly).
  • add in src/afl-fuzz.c usage() an ifdef line that prints Compiled (not) with UTF8 suppport (as are other similar options).

thank you!

@ThomasTNO
Copy link
Contributor Author

No worries, should be good to go.

@ThomasTNO
Copy link
Contributor Author

@andreafioraldi, I do not develop for Android, nor use adb. I see that you introduced the disabling of fancy_boxes for Android compilation. Does UTF-8 rendering work in adb as well?

i.e. can we remove this compilation exception for Android?

@vanhauser-thc
Copy link
Member

Andrea is on vacation currently. via adb the rendering is on the host so I do not see why this would break this. output on android itself (app, serial, ...) - but android's default is utf8 too.
so I' d say remove the android restriction and if someone complains it can still be reverted (or user sets NO_UTF8).

@ThomasTNO
Copy link
Contributor Author

Sure, thing. Feel free to merge it in its current state.

@ThomasTNO
Copy link
Contributor Author

@vanhauser-thc, no clue why the test on Ubuntu-22.04 fails. Do you have any thoughts?

@vanhauser-thc
Copy link
Member

The fail is a change in gcc, not important.
Thank you!

@vanhauser-thc vanhauser-thc merged commit 14bca44 into AFLplusplus:dev Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants