Remove redundant comparison of fav_factor in update_bitmap_score
#1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`top_rated_fav_factor` was actually calculated twice, but only one calculation and comparison is needed. Since `fav_factor` > `top_rated_fav_factor` will always cause skip of current iteration, `else if (fuzz_p2 == top_rated_fuzz_p2)` is also redundant.
Member
|
you are right, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing
update_bitmap_score, I get confused about the logic of comparingfav_factorandtop_rated_fav_factorthen skip the loop.top_rated_fav_factorwas actually calculated twice, but only one calculation and comparison is needed. The replacement shown below should not change the semantic of this code.Since now
fav_factor>top_rated_fav_factorin the loop will always cause skip of current iteration,else if (fuzz_p2 == top_rated_fuzz_p2)is also redundant.if (fuzz_p2 > top_rated_fuzz_p2) { continue; - } else if (fuzz_p2 == top_rated_fuzz_p2) { - - if (fav_factor > top_rated_fav_factor) { continue; } - } if (fav_factor > top_rated_fav_factor) continue;Finally we get two simple condition that skip current iteration.