C++ compilation should use CPPFLAGS #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I am afk - is the gcc plugin makefile affected too? |
jschwartzentruber
force-pushed
the
cxx-use-cppflags
branch
from
4389c5b to
82635dc
Compare
Contributor
Author
Yes, you're right. Updated. |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPPFLAGSshould be used for C++ compilation too (ref: implicit GNU Make rule).This makes it easier to use
--sysrootwhen required, which needs to be used with all flag variations:CFLAGS,CFLAGS_SAFE, andCXXFLAGS.