Skip to content

Conversation

@mark0-cn
Copy link
Contributor

image

mark0-cn added 2 commits July 29, 2023 14:57
Fix bug: compilation cannot pass when DEBUG macro is enabled
Fix bug: compilation cannot pass when DEBUG macro is enabled
@domenukk
Copy link
Member

Is this fine on Linux, MacOS and gcc and clang? IIRC the platform independent / correct way would be to use , "%" PRId64, here (but it's super ugly so I'd prefer %lld if it works fine..)

@mark0-cn
Copy link
Contributor Author

Is this fine on Linux, MacOS and gcc and clang? IIRC the platform independent / correct way would be to use , "%" PRId64, here (but it's super ugly so I'd prefer %lld if it works fine..)

I find this issue on MacOS and have not tried it on other platforms. But I feel like there's no problem on other platforms either. Perhaps it would be better to change to '%' PRId64?

@domenukk
Copy link
Member

Probably safer, yes, IIRC on linux sometimes I needed %ld instead of %lld specifically, but I don't have a machine to test right now

@domenukk
Copy link
Member

Tried it, seems fine, thanks! :)

@domenukk domenukk merged commit 168ade3 into AFLplusplus:dev Jul 30, 2023
@domenukk
Copy link
Member

Oops actually now it warns on linux, will fix it manually

domenukk added a commit that referenced this pull request Jul 30, 2023
@domenukk
Copy link
Member

Fixed in d0782a7

@mark0-cn mark0-cn deleted the dev branch July 31, 2023 00:42
@mark0-cn mark0-cn restored the dev branch July 31, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants