push to stable #1798
Merged
push to stable #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix MAX_PARAMS_NUM define.
remove extra limits.h in afl-ld-lto for BSD
Increase dummy map size
hexcoder-
reviewed
Jul 13, 2023
Member
hexcoder-
left a comment
hexcoder-
left a comment
There was a problem hiding this comment.
Apart from two small nits, I approve it.
- The typo was fixed by myself.
- The MAP_SIZE copy-and-paste change I leave to you.
| static GHashTable *coverage_blocks = NULL; | ||
|
|
||
| __attribute__((aligned(0x1000))) static guint8 area_ptr_dummy[MAP_SIZE]; | ||
| __attribute__((aligned(0x1000))) static guint8 area_ptr_dummy[2UL << 20]; |
Member
There was a problem hiding this comment.
Now we have two size definitions '2UL << 20' in instrument_arm32.cpp and ...64.cpp (before we had one definition MAP_SIZE). I prefer the one definition rule.
hexcoder-
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.