Transaction status result optimization #3625
Merged
+106
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks(click to expand)77.60%[...src/AElf.WebApp.Application.Chain/Dto/TransactionResultDt] 93.86%[...src/AElf.WebApp.Application.Chain/Services/TransactionRes] 98.54%[protobuf/aelf/core.proto] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3625 +/- ##
===========================================
- Coverage 90.53% 73.44% -17.10%
===========================================
Files 677 678 +1
Lines 26104 26424 +320
Branches 2353 2440 +87
===========================================
- Hits 23634 19406 -4228
- Misses 2355 6859 +4504
- Partials 115 159 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eanzhao
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Status is obsolete in this version. For issue #3623