Deduplicate closing balance during mutual close #3182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a mutual close transaction is published or recently confirmed, we don't include the corresponding channel in our off-chain balance to avoid counting it twice (which would resolve itself after confirmations but is misleading). There are degenerate cases where the channel will actually end up being force-closed, even though we started with a mutual close, but that will be very infrequent and will resolve itself after confirmations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a mutual close transaction is published or recently confirmed, we don't include the corresponding channel in our off-chain balance to avoid counting it twice (which would resolve itself after confirmations but is misleading).
There are degenerate cases where the channel will actually end up being force-closed, even though we started with a mutual close, but that will be very infrequent and will resolve itself after confirmations.