Fix encoding of channel type TLV in splice_init/splice_ack #3178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The channel type codec that we use is a "TLV field codec", wrapping it in a tlvField() codec was wrong and messed up the encoding.
t-bast
reviewed
Sep 23, 2025
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Good catch! We should have added an encoding unit test right from the beginning, we would have detected this earlier.
eclair-core/src/test/scala/fr/acinq/eclair/wire/protocol/LightningMessageCodecsSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/wire/protocol/LightningMessageCodecsSpec.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastien Teinturier <[email protected]>
t-bast
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel type codec that we use is a "TLV field codec", wrapping it in a tlvField() codec was wrong and messed up the encoding.