Reject offers with some fields present but empty #3175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offers or invoices where the fields `offer_chains`, `offer_paths`, `invoice_paths`, `invoice_blindedpay` are present but empty are considered invalid. While the spec does not necessarily rejects them explicitly, they can't be paid.
t-bast
reviewed
Sep 22, 2025
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Can you also add the test vector you added to lightning-kmp? Is there a reason why it wasn't included?
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/OfferCodecs.scala
Outdated
Show resolved
Hide resolved
thomash-acinq
commented
Sep 22, 2025
Member
Author
thomash-acinq
left a comment
thomash-acinq
left a comment
There was a problem hiding this comment.
The test vector from lightning-kmp was already behaving well in eclair before this PR. I've now added a similar test for each of the field I've modified.
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/OfferCodecs.scala
Outdated
Show resolved
Hide resolved
t-bast
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offers or invoices where the fields
offer_chains,offer_paths,invoice_paths,invoice_blindedpayare present but empty are considered invalid. While the spec does not necessarily rejects them explicitly, they can't be paid.