Skip to content

Conversation

@thomash-acinq
Copy link
Member

@thomash-acinq thomash-acinq commented Jun 17, 2025

Hold times in attribution data now use decaseconds instead of milliseconds.
lightning/bolts#1044

Hold times in attribution data now use decaseconds instead of milliseconds
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (f14b92d) to head (f9a6a06).
Report is 15 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3112      +/-   ##
==========================================
+ Coverage   85.80%   85.99%   +0.19%     
==========================================
  Files         236      238       +2     
  Lines       21299    21616     +317     
  Branches      859      819      -40     
==========================================
+ Hits        18275    18589     +314     
- Misses       3024     3027       +3     
Files with missing lines Coverage Δ
...src/main/scala/fr/acinq/eclair/crypto/Sphinx.scala 99.28% <100.00%> (-0.72%) ⬇️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thomash-acinq thomash-acinq requested a review from t-bast June 17, 2025 12:24
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's ship this 🚀

@thomash-acinq thomash-acinq merged commit 8abb525 into master Jun 17, 2025
1 check passed
@thomash-acinq thomash-acinq deleted the hold-times-100ms branch June 17, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants