Remove duplication around skipping dust transactions #3068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of duplicated code where we skip creating 2nd-stage and 3rd-stage transactions when their output would be below dust. We now introduce a helper function to factorize this shared behavior.
t-bast
force-pushed
the
refactor-tx-skip-dust
branch
from
f458443 to
97e4b35
Compare
sstone
reviewed
Apr 24, 2025
eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala
Outdated
Show resolved
Hide resolved
sstone
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactoring to remove some duplication around skipping transactions whose output is below dust. We had a lot of copy-pasted code, which was a bit error-prone. I don't know if we should go further and try also factoring the part that creates/modifies the dummy signed transaction: it's less obvious how to do that while maintaining readability, and it may be obsolete once we've cleaned up
Transactions.scalamore in depth.