Fix flaky GossipIntegrationSpec test #3039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Alice receives `ExternalChannelSpentTriggered` after validating the local channel update for the splice, then the original funding tx will not be in the `spentChannels` list and the splice will be added to the routing graph as a new channel. When `ExternalChannelSpentTriggered` is received, it will add Alice's funding tx to `spentChannels` and cause the assert in issue 3033. This is unlikely to occur in the wild and if it does, the original funding tx will be removed when the splice tx that spends it confirms.
remyers
added a commit
to remyers/eclair
that referenced
this pull request
Apr 11, 2025
Apply same fix to Bob and Carol used for Alice. Race can result in `ExternalChannelSpent` being received by nodes after validating the channel update for a splice received from their peer. This will not happen in the wild. I checked that both paths are exercised for all three nodes.
remyers
added a commit
to remyers/eclair
that referenced
this pull request
Apr 11, 2025
Apply same fix to Bob and Carol used for Alice. Race can result in `ExternalChannelSpent` being received by nodes after validating the channel update for a splice received from their peer. This will not happen in the wild. I checked that both paths are exercised for all three nodes.
remyers
added a commit
that referenced
this pull request
Apr 14, 2025
Apply same fix to Bob and Carol used for Alice. Race can result in `ExternalChannelSpent` being received by nodes after validating the channel update for a splice received from their peer. This will not happen in the wild. I checked that both paths are exercised for all three nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Alice receives
ExternalChannelSpentTriggeredafter validating the local channel update for the splice, then the original funding tx will not be in thespentChannelslist and the splice will be added to the routing graph as a new channel.When
ExternalChannelSpentTriggeredis received, it will add Alice's funding tx tospentChannelsand cause the assert in issue #3033 .This is unlikely to occur in the wild and if it does, the original funding tx will be removed when the splice tx that spends it confirms.