Use long id instead of short id in ChannelRelay
#2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
force-pushed
the
rework-channelrelayer-maps
branch
from
86ab16f to
a6381d1
Compare
t-bast
reviewed
May 18, 2022
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelayer.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/payment/relay/ChannelRelayerSpec.scala
Show resolved
Hide resolved
t-bast
reviewed
May 19, 2022
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala
Outdated
Show resolved
Hide resolved
t-bast
approved these changes
May 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #2221 +/- ##
==========================================
- Coverage 84.35% 84.30% -0.05%
==========================================
Files 194 194
Lines 14393 14411 +18
Branches 612 568 -44
==========================================
+ Hits 12141 12149 +8
- Misses 2252 2262 +10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for lightning/bolts#910.
The relaying logic is now based on the
channelIdinstead ofshortChannelId.We used to consider
shortChannelIdas a unique identifier for thechannel, but it's not true anymore: there will be multiple aliases per
channel.