common-api-v2/gadi/packages.yaml: externals are treated as concrete specs#99
Merged
common-api-v2/gadi/packages.yaml: externals are treated as concrete specs#99
Conversation
…pecs * As of spack/spack#51118 we need to accommodate: "To be backward compatible with external specs specifying a compiler, for instance mpich %gcc@9, Spack will match the compiler specification to an existing external. It will fail when the specification is ambiguous, or if it does not match any other externals."
Collaborator
Author
Testing |
CodeGat
approved these changes
Feb 6, 2026
harshula
added a commit
that referenced
this pull request
Feb 6, 2026
…#99) * As of spack/spack#51118 we need to accommodate: "To be backward compatible with external specs specifying a compiler, for instance mpich %gcc@9, Spack will match the compiler specification to an existing external. It will fail when the specification is ambiguous, or if it does not match any other externals." * We can no longer specify only the compiler name. If we specify the compiler name, then we must include a compiler version.
harshula
added a commit
that referenced
this pull request
Feb 6, 2026
…#99) * As of spack/spack#51118 we need to accommodate: "To be backward compatible with external specs specifying a compiler, for instance mpich %gcc@9, Spack will match the compiler specification to an existing external. It will fail when the specification is ambiguous, or if it does not match any other externals." * We can no longer specify only the compiler name. If we specify the compiler name, then we must include a compiler version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"To be backward compatible with external specs specifying a compiler, for
instance mpich %gcc@9, Spack will match the compiler specification to an
existing external. It will fail when the specification is ambiguous, or
if it does not match any other externals."