Skip to content

Remove 'Rolling Tag' logic for Prereleases#86

Merged
CodeGat merged 1 commit intomainfrom
85-spack-fetch-tags-clobbering-fix
May 24, 2024
Merged

Remove 'Rolling Tag' logic for Prereleases#86
CodeGat merged 1 commit intomainfrom
85-spack-fetch-tags-clobbering-fix

Conversation

@CodeGat
Copy link
Copy Markdown
Member

@CodeGat CodeGat commented May 24, 2024 •
edited
Loading

We are removing the rolling tag logic because it is causing spack installs to fail. This is because when updating the repository in spack, it fails to git fetch --tags because it would clobber the existing tags.
Removes functionality introduced in the CI (back when it was a part of the model) in ACCESS-NRI/ACCESS-OM2#47

In this PR:

  • ci.yml: Removed shifting tag logic for prereleases, now only do it initially.

References #85

@CodeGat CodeGat self-assigned this May 24, 2024
aidanheerdegen
aidanheerdegen approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we still tag again on merge.

@CodeGat
Copy link
Copy Markdown
Member Author

CodeGat commented May 24, 2024

Indeed we do. That is handled in cd.yml, specifically here:

build-cd/.github/workflows/cd.yml

Lines 25 to 47 in 06ed17b

push-tag:
name: Tag Deployment
runs-on: ubuntu-latest
permissions:
contents: write
outputs:
name: ${{ steps.tag.outputs.name }}
steps:
- uses: actions/checkout@v4
- name: Generate Tag
id: tag
# Get the tag name from the `spack.yaml` that was merged into main, which
# is of the form `<model>@git.<version>`.
run: echo "name=$(yq '${{ env.SPACK_YAML_MODEL_YQ }} | split("@git.") | .[1]' spack.yaml)" >> $GITHUB_OUTPUT
- name: Push Tag
# NOTE: Regarding the config user.name/user.email, see https://github.com/actions/checkout/pull/1184
run: |
git config user.name ${{ vars.GH_ACTIONS_BOT_GIT_USER_NAME }}
git config user.email ${{ vars.GH_ACTIONS_BOT_GIT_USER_EMAIL }}
git tag ${{ steps.tag.outputs.name }} --force
git push --tags --force
:)

@CodeGat CodeGat merged commit 50ccf77 into main May 24, 2024
@CodeGat CodeGat deleted the 85-spack-fetch-tags-clobbering-fix branch May 24, 2024 03:31
@CodeGat CodeGat mentioned this pull request Aug 21, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@CodeGat CodeGat

Labels

priority:blocker type:bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CodeGat @aidanheerdegen